-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalidate user session on password reset #45139
Conversation
Just a static check failure :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubhamraj-git nice work on the PR. Could you please change the PR title to something better, like "Invalidate a session on password change"?
9e2b387
to
86dd8de
Compare
This is provider-only change - so we do not need to backport it. |
Not so simple. It was decided that fab provider next release is breaking change and compatible with Airflow 3 only. to release this change to fab provider that is compatible with Airflow 2.9 we need to create a branch from fab tag 1.5.1 and follow on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, looks good now +1
Indeed. First time!. So wiil simply need to create a branch from FAB and use cherry-picker to cherry-pick it there after merging. Probably manual |
…e#45139) * session expire on pass change * fix statis checks * add tests (cherry picked from commit cf401c4) Co-authored-by: Shubham Raj <[email protected]>
…e#45139) * session expire on pass change * fix statis checks * add tests (cherry picked from commit cf401c4) Co-authored-by: Shubham Raj <[email protected]>
…e#45139) * session expire on pass change * fix statis checks * add tests (cherry picked from commit cf401c4) Co-authored-by: Shubham Raj <[email protected]>
…e#45139) * session expire on pass change * fix statis checks * add tests (cherry picked from commit cf401c4) Co-authored-by: Shubham Raj <[email protected]>
…e#45139) * session expire on pass change * fix statis checks * add tests (cherry picked from commit cf401c4) Co-authored-by: Shubham Raj <[email protected]>
…e#45139) * session expire on pass change * fix statis checks * add tests (cherry picked from commit cf401c4) Co-authored-by: Shubham Raj <[email protected]> Avoid 1.1.8 version of msgraph-core (apache#45044) The 1.1.8 version of msgraph-core is buggy - importing some basic classes causes import error "ABCMeta" is not subscriptable. We are removing the version from azure provider dependencies hoping that it will be fixed in the next version. microsoftgraph/msgraph-sdk-python-core#781 (cherry picked from commit 3310b86)
Session expire on pass change
The key difference is automatic transaction handling in the UI vs the manual control required in CLI operations. In the CLI, it does not automatically commit the session unless you explicitly tell it to, while the UI framework does this at the end of a successful request. So, session.commit() is added.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.